npawar commented on pull request #6667: URL: https://github.com/apache/incubator-pinot/pull/6667#issuecomment-813663306
> Please address `PartitionGroupMetadata vs PartitionGroupInfo`. > > LGTM otherwise. @snleee @sajjad-moradi @mcvsubbu Addressed the PartitionGroup Info/Metadata discussion. The input class has been renamed to `PartitionGroupStatus`. The output class has been renamed to `PartitionGroupMetadata`. The API in `StreamMetadataProvider` now reads as ``` /** * Computes the list of {@link PartitionGroupMetadata} for the latest state of the stream, using the current {@link PartitionGroupStatus} * * Default behavior is the one for the Kafka stream, where each partition group contains only one partition * @param partitionGroupStatus list of {@link PartitionGroupStatus} for current partition groups */ default List<PartitionGroupMetadata> computePartitionGroupMetadata(String clientId, StreamConfig streamConfig, List<PartitionGroupStatus> partitionGroupStatus, int timeoutMillis) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org