npawar commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r606509461
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java
##########
@@ -352,12 +367,7 @@ public long getSegmentSizeBytes() {
}
public String getStreamPartitionMsgOffset() {
- if (_streamPartitionMsgOffset != null) {
- return _streamPartitionMsgOffset;
- } else {
- // TODO 5359 remove this once we are all upgraded in controllers and
servers.
Review comment:
You mean release 0.5.0 where your changes for StreamPartitionMsgOffset
went in rt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
