npawar commented on pull request #6667: URL: https://github.com/apache/incubator-pinot/pull/6667#issuecomment-813663686
> > Overall lgtm. Comments are relatively minor. > > @snleee , @sajjad-moradi do you have any strong concerns? > > It looks good to me too. > Minor comment: I agree with Subbu's comment about rubber-stamping a separate PR for renaming: xxxPartitionYYY -> xxxParitionGroupYYY I think most spots were renamed to `partitionGroupXX`. So corrected the ones that were pointed out in the review in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
