npawar commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r606507565
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -238,6 +240,7 @@ public void deleteSegmentFile() {
// Segment end criteria
private volatile long _consumeEndTime = 0;
+ private boolean _endOfPartitionGroup = false;
Review comment:
Only 1 thread is using this. The same thread that writes it in
consumeLoop and then checks it also in consumeLoop. In that case it doesn't
need to be volatile rt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
