mqliang commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r595642761
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/InstanceResponseBlock.java
##########
@@ -41,6 +41,9 @@
public InstanceResponseBlock(IntermediateResultsBlock
intermediateResultsBlock) {
try {
_instanceResponseDataTable = intermediateResultsBlock.getDataTable();
+ long totalThreadCpuTimeNs =
intermediateResultsBlock.getThreadCpuTimeNs();
+
_instanceResponseDataTable.getMetadata().put(DataTable.THREAD_CPU_TIME_NS_METADATA_KEY,
Review comment:
If we don't set the value as DataTable metadata here, then it's
impossible to get the value in QueryScheduler.java, in other words, we should
delete the ServerGauge emitting code also. I think at this moment, we can just
put a log line here, and deleting the change in QueryScheduler.java.
Another workaround is: add the value as DataTable metadata here, but in
QueryScheduler.java, after writing log and emitting ServerGauge,
`dataTable.getMetadata().remove(DataTable.THREAD_CPU_TIME_NS_METADATA_KEY)` so
that this value will NOT be send back to broker (and add a TODO stating remove
it when we have data table serialization cost measuring).
Any preference between the two option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
