mcvsubbu commented on a change in pull request #6680:
URL: https://github.com/apache/incubator-pinot/pull/6680#discussion_r595594826
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -317,6 +317,9 @@
public static final String ACCESS_CONTROL_FACTORY_CLASS =
"pinot.server.admin.access.control.factory.class";
public static final String DEFAULT_ACCESS_CONTROL_FACTORY_CLASS =
"org.apache.pinot.server.api.access.AllowAllAccessFactory";
+
+ public static final String CONFIG_OF_ENABLE_THREAD_CPU_TIME_INSTRUMENT =
"pinot.server.instance.enableThreadCpuTimeInstrument";
+ public static final boolean DEFAULT_ENABLE_THREAD_CPU_TIME_INSTRUMENT =
true;
Review comment:
default should be false, at least for now
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java
##########
@@ -65,6 +65,7 @@
SEGMENT_DOWNLOAD_FAILURES("segments", false),
NUM_RESIZES("numResizes", false),
RESIZE_TIME_MS("resizeTimeMs", false),
+ THREAD_CPU_TIME_NS("threadCpuTimeNs", false),
Review comment:
should be in `ServerGauge` not `ServerMeter`. Also looks like
`RESIZE_TIME` is in the wrong place. Should be a gauge. You can fix that in a
separate PR
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/InstanceResponseBlock.java
##########
@@ -41,6 +41,9 @@
public InstanceResponseBlock(IntermediateResultsBlock
intermediateResultsBlock) {
try {
_instanceResponseDataTable = intermediateResultsBlock.getDataTable();
+ long totalThreadCpuTimeNs =
intermediateResultsBlock.getThreadCpuTimeNs();
+
_instanceResponseDataTable.getMetadata().put(DataTable.THREAD_CPU_TIME_NS_METADATA_KEY,
Review comment:
Do we want to hold off on this until we also add the serialization part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
