mcvsubbu commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r593537950
##########
File path:
pinot-controller/src/test/resources/recommenderInput/RealtimeProvisioningInput.json
##########
@@ -0,0 +1,170 @@
+{
+ "schema":{
+ "schemaName": "tableSchema",
+ "dimensionFieldSpecs": [
+ {
+ "name": "a",
+ "dataType": "INT",
+ "cardinality":20,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "b",
+ "dataType": "DOUBLE",
+ "cardinality":6,
+ "numValuesPerEntry":1.5,
+ "singleValueField": false
+ },
+ {
+ "name": "c",
+ "dataType": "FLOAT",
+ "cardinality":7,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "d",
+ "dataType": "STRING",
+ "cardinality":41,
+ "numValuesPerEntry":2,
+ "averageLength" : 27,
+ "singleValueField": false
+ },
+ {
+ "name": "e",
+ "dataType": "LONG",
+ "cardinality":18,
+ "numValuesPerEntry":4,
+ "singleValueField": false
+ },
+ {
+ "name": "f",
+ "dataType": "DOUBLE",
+ "cardinality":13,
+ "numValuesPerEntry":3,
+ "singleValueField": false
+ },
+ {
+ "name": "g",
+ "dataType": "STRING",
+ "cardinality":6,
+ "numValuesPerEntry":2,
+ "averageLength" : 100,
+ "singleValueField": false
+ },
+ {
+ "name": "h",
+ "dataType": "BYTES",
+ "cardinality":12,
+ "numValuesPerEntry":1,
+ "averageLength" : 10
+ },
+ {
+ "name": "i",
+ "dataType": "STRING",
+ "cardinality":7,
+ "numValuesPerEntry":1,
+ "averageLength" : 25,
+ "singleValueField": false
+ },
+ {
+ "name": "j",
+ "dataType": "DOUBLE",
+ "cardinality":4,
+ "numValuesPerEntry":1.00000001,
+ "singleValueField": false
+ }
+ ],
+ "metricFieldSpecs": [
+ {
+ "name": "k",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 100
+ },
+ {
+ "name": "l",
+ "dataType": "STRING",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 10
+ },
+ {
+ "name": "m",
+ "dataType": "BYTES",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 25
+ },
+ {
+ "name": "n",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "o",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 25
+ },
+ {
+ "name": "p",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1
+ }
+ ],
+ "timeFieldSpec": {
Review comment:
We should do all testing from now on with DateTimeFieldSpec, since
TimeFieldSpec is deprecated.
##########
File path:
pinot-controller/src/test/resources/recommenderInput/RealtimeProvisioningInput.json
##########
@@ -0,0 +1,170 @@
+{
+ "schema":{
+ "schemaName": "tableSchema",
+ "dimensionFieldSpecs": [
+ {
+ "name": "a",
+ "dataType": "INT",
+ "cardinality":20,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "b",
+ "dataType": "DOUBLE",
+ "cardinality":6,
+ "numValuesPerEntry":1.5,
+ "singleValueField": false
+ },
+ {
+ "name": "c",
+ "dataType": "FLOAT",
+ "cardinality":7,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "d",
+ "dataType": "STRING",
+ "cardinality":41,
+ "numValuesPerEntry":2,
+ "averageLength" : 27,
+ "singleValueField": false
+ },
+ {
+ "name": "e",
+ "dataType": "LONG",
+ "cardinality":18,
+ "numValuesPerEntry":4,
+ "singleValueField": false
+ },
+ {
+ "name": "f",
+ "dataType": "DOUBLE",
+ "cardinality":13,
+ "numValuesPerEntry":3,
+ "singleValueField": false
+ },
+ {
+ "name": "g",
+ "dataType": "STRING",
+ "cardinality":6,
+ "numValuesPerEntry":2,
+ "averageLength" : 100,
+ "singleValueField": false
+ },
+ {
+ "name": "h",
+ "dataType": "BYTES",
+ "cardinality":12,
+ "numValuesPerEntry":1,
+ "averageLength" : 10
+ },
+ {
+ "name": "i",
+ "dataType": "STRING",
+ "cardinality":7,
+ "numValuesPerEntry":1,
+ "averageLength" : 25,
+ "singleValueField": false
+ },
+ {
+ "name": "j",
+ "dataType": "DOUBLE",
+ "cardinality":4,
+ "numValuesPerEntry":1.00000001,
+ "singleValueField": false
+ }
+ ],
+ "metricFieldSpecs": [
+ {
+ "name": "k",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 100
+ },
+ {
+ "name": "l",
+ "dataType": "STRING",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 10
+ },
+ {
+ "name": "m",
+ "dataType": "BYTES",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 25
+ },
+ {
+ "name": "n",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1
+ },
+ {
+ "name": "o",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1,
+ "averageLength" : 25
+ },
+ {
+ "name": "p",
+ "dataType": "DOUBLE",
+ "cardinality":1000,
+ "numValuesPerEntry":1
+ }
+ ],
+ "timeFieldSpec": {
+ "incomingGranularitySpec": {
+ "dataType": "INT",
+ "name": "t",
+ "timeType": "DAYS",
+ "cardinality":1000,
Review comment:
Cardinality is important only on a per-segment basis, right? I am not
sure if we are considering that. For example, in an additive table with daily
push, the cardinalty of a column with type DAYS is likely 1 or 2 at best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
