siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r572443033



##########
File path: 
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/DataGeneratorSpec.java
##########
@@ -38,6 +38,8 @@
   private final Map<String, Integer> cardinalityMap;
   private final Map<String, IntRange> rangeMap;
   private final Map<String, Map<String, Object>> patternMap;
+  private final Map<String, Double> mvCountMap; // map of column name to 
average number of values per entry
+  private final Map<String, Integer> lengthMap; // map of column name to 
average length of th entry (used for string generator)

Review comment:
       Both for string and bytes right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to