siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r572442856
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/data/generator/DataGenerator.java
##########
@@ -163,26 +174,75 @@ private FieldSpec buildSpec(DataGeneratorSpec genSpec,
String column) {
public static void main(String[] args)
throws IOException {
- final String[] columns = {"column1", "column2", "column3", "column4",
"column5"};
+
final Map<String, DataType> dataTypes = new HashMap<>();
final Map<String, FieldType> fieldTypes = new HashMap<>();
final Map<String, TimeUnit> timeUnits = new HashMap<>();
final Map<String, Integer> cardinality = new HashMap<>();
final Map<String, IntRange> range = new HashMap<>();
final Map<String, Map<String, Object>> template = new HashMap<>();
-
- for (final String col : columns) {
- dataTypes.put(col, DataType.INT);
- fieldTypes.put(col, FieldType.DIMENSION);
- cardinality.put(col, 1000);
+ Map<String, Double> mvCountMap = new HashMap<>();
+ Map<String, Integer> lengthMap = new HashMap<>();
+ List<String> columnNames = new ArrayList<>();
+
+ int cardinalityValue = 5;
+ int strLength = 5;
+
+ String colName = "colInt";
+ dataTypes.put(colName, DataType.INT);
Review comment:
Sorry, I don't follow these changes. All of this information (column
name, type etc) should come from the data characteristics file. What is colInt
then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
