siddharthteotia commented on a change in pull request #6546:
URL: https://github.com/apache/incubator-pinot/pull/6546#discussion_r572440543
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -71,9 +72,15 @@
@Option(name = "-numHours", metaVar = "<String>", usage = "number of hours
to consume as comma separated values (default 2,3,4,5,6,7,8,9,10,11,12)")
private String _numHours = "2,3,4,5,6,7,8,9,10,11,12";
- @Option(name = "-sampleCompletedSegmentDir", required = true, metaVar =
"<String>", usage = "Consume from the topic for n hours and provide the path of
the segment dir after it completes")
+ @Option(name = "-sampleCompletedSegmentDir", required = false, metaVar =
"<String>", usage = "Consume from the topic for n hours and provide the path of
the segment dir after it completes")
private String _sampleCompletedSegmentDir;
+ @Option(name = "-dataCharacteristicsFile", required = false, metaVar =
"<String>", usage = "File containing characteristics by which a segment will be
generated")
+ private String _dataCharacteristicsFile;
+
+ @Option(name = "-schemaFile", required = false, metaVar = "<String>")
Review comment:
We should not provide schema file. See my comment further below. The
data characteristics file is essentially the schema annotated with additional
info. So it alone should be enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
