JoeFuentes-WebDev commented on a change in pull request #6472:
URL: https://github.com/apache/incubator-pinot/pull/6472#discussion_r562879413
##########
File path: thirdeye/thirdeye-frontend/app/pods/manage/explore/route.js
##########
@@ -12,9 +12,14 @@ import { formatYamlFilter, redundantParse } from
'thirdeye-frontend/utils/yaml-t
import moment from 'moment';
import AuthenticatedRouteMixin from
'ember-simple-auth/mixins/authenticated-route-mixin';
+const ANALYSIS_RANGE = [
+ moment().add(1, 'day').subtract(30, 'day').startOf('day').valueOf(),
+ moment().add(1, 'day').startOf('day').valueOf()
+];
+
Review comment:
OK. I agree with postponing the `30-day` hardcoding. But, I will would
like to have it moved to the constants file.
I am seeing that it is use in 2 other places and it would make sense you
just `re-`use it. In addition, if we decide to change the hardcoded aspect,
then it will be done in one place and applied everywhere it is used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
