tejasajmera commented on a change in pull request #6472:
URL: https://github.com/apache/incubator-pinot/pull/6472#discussion_r562865959
##########
File path: thirdeye/thirdeye-frontend/app/pods/manage/explore/route.js
##########
@@ -106,16 +116,16 @@ export default Route.extend(AuthenticatedRouteMixin, {
notifications.error('Retrieving subscription groups failed.', error,
toastOptions);
}
- let subscribedGroups = "";
+ let subscribedGroups = '';
if (typeof get(this, 'subscriptionGroups') === 'object' && get(this,
'subscriptionGroups').length > 0) {
const groups = get(this, 'subscriptionGroups');
for (let key in groups) {
- if (groups.hasOwnProperty(key)) {
+ if (key in groups) {
let group = groups[key];
Review comment:
I realized I was trying to correct the `eslint` error in an incorrect
way. I should be doing `if ({}.propertyIsEnumerable.call(groups, key))`. Using
`Object.keys(groups).forEach(group) { ...} ` will work, but it involves usage
of extra memory for creating the array and an O(N) processing,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
