tejasajmera commented on a change in pull request #6472:
URL: https://github.com/apache/incubator-pinot/pull/6472#discussion_r562844274
##########
File path: thirdeye/thirdeye-frontend/app/pods/manage/explore/route.js
##########
@@ -12,9 +12,14 @@ import { formatYamlFilter, redundantParse } from
'thirdeye-frontend/utils/yaml-t
import moment from 'moment';
import AuthenticatedRouteMixin from
'ember-simple-auth/mixins/authenticated-route-mixin';
+const ANALYSIS_RANGE = [
+ moment().add(1, 'day').subtract(30, 'day').startOf('day').valueOf(),
+ moment().add(1, 'day').startOf('day').valueOf()
+];
+
Review comment:
I think yes you are right. I think we may want to have it programatic
based on the month. But I am not 100% sure yet, will need to confirm and see if
there was a rationale to hardcode it to 30 in the first place. As you said, we
don't want to address tangential things in this PR, so in one of the future
PR's we'd address it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
