amarnathkarthik commented on a change in pull request #6385:
URL: https://github.com/apache/incubator-pinot/pull/6385#discussion_r549153448
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
##########
@@ -87,6 +89,7 @@ public static URI generateSegmentTarURI(URI dirURI, URI
fileURI, String prefix,
public static void pushSegments(SegmentGenerationJobSpec spec, PinotFS
fileSystem, List<String> tarFilePaths)
throws RetriableOperationException, AttemptsExceededException {
String tableName = spec.getTableSpec().getTableName();
+ boolean cleanUpOutputDir = spec.isCleanUpOutputDir();
Review comment:
For readability and `spec.isCleanUpOutputDir()` is a kind of constant
within the method which does not change in the nested for-loop thought defining
a variable in outer scope will be helpful. Let me know if you would want to
just go with `spec.isCleanUpOutputDir()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
