amarnathkarthik commented on a change in pull request #6385:
URL: https://github.com/apache/incubator-pinot/pull/6385#discussion_r548963111
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
##########
@@ -134,6 +135,8 @@ public static void pushSegments(SegmentGenerationJobSpec
spec, PinotFS fileSyste
segmentName, controllerURI, e);
throw e;
}
+ } finally {
+ FileUtils.deleteQuietly(tarFile);
Review comment:
Added `_cleanUpOutputDir` in jobSpec and defaults to `false`. Have
tested for jobType `SegmentCreationAndTarPush` and `SegmentCreationAndUriPush`
with `_cleanUpOutputDir=true/false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
