mayankshriv commented on a change in pull request #6385:
URL: https://github.com/apache/incubator-pinot/pull/6385#discussion_r549147486
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
##########
@@ -87,6 +89,7 @@ public static URI generateSegmentTarURI(URI dirURI, URI
fileURI, String prefix,
public static void pushSegments(SegmentGenerationJobSpec spec, PinotFS
fileSystem, List<String> tarFilePaths)
throws RetriableOperationException, AttemptsExceededException {
String tableName = spec.getTableSpec().getTableName();
+ boolean cleanUpOutputDir = spec.isCleanUpOutputDir();
Review comment:
Any specific reason to create this variable, as opposed to using
`spec.isCleanupOutputDir()` inline, given that it is just used in one place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
