mcvsubbu commented on pull request #6286: URL: https://github.com/apache/incubator-pinot/pull/6286#issuecomment-736947530
> > > I remember adding support in Helix where you simply mention the replication factor as N and Helix will assign a segment to all nodes in the cluster that match the tag. Can we use that? > > > > > > I suggest not to use the helix mechanism (even if it is available) -- for operational ease. "Pinot code controls segment assignment" -- is much easier to reason about, than looking up whether isDimTable is set to know what is going on. > > @mcvsubbu I was curious about this suggestion. I think the purpose is to have a declarative way of segment assignment for the DimTable, but leave the actual implementation to the corresponding module, be it Helix or Pinot. Is there a particular reason that we shall not consider Helix? Is it due to reliability or some other considerations? The idea is two-fold: 1. It is better we have the same pattern of assigning segments -- that of using a specific segment assignment strategy. Just add another name, and write the code for it, it should be fairly small, as has been demonstrated in this PR. 2. If Helix (for whatever reason) changes behavior, Pinot will not suffer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
