dharakk commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r533162386
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignmentUtils.java
##########
@@ -87,6 +87,15 @@ private SegmentAssignmentUtils() {
return instances;
}
+ static List<String> getInstancesForDimTable(InstancePartitions
instancePartitions) {
+ Preconditions
+ .checkState(instancePartitions.getNumReplicaGroups() == 1 &&
instancePartitions.getNumPartitions() == 1,
+ "Instance partitions: %s should contain 1 replica and 1
partition for a dim table",
Review comment:
Removed this way of gathering hosts and now getting hosts from a given
tag directly. In this case the replication number as such will be disregarded
and by default we will assign to all the segment to all the hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
