dharakk commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r533165128
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/TableDataManagerProvider.java
##########
@@ -51,13 +52,17 @@ public static TableDataManager getTableDataManager(@Nonnull
TableDataManagerConf
@Nonnull String instanceId, @Nonnull ZkHelixPropertyStore<ZNRecord>
propertyStore,
@Nonnull ServerMetrics serverMetrics, @Nonnull HelixManager
helixManager) {
TableDataManager tableDataManager;
- switch
(TableType.valueOf(tableDataManagerConfig.getTableDataManagerType())) {
+ switch
(TableDataManagerType.valueOf(tableDataManagerConfig.getTableDataManagerType()))
{
case OFFLINE:
tableDataManager = new OfflineTableDataManager();
break;
case REALTIME:
tableDataManager = new
RealtimeTableDataManager(_segmentBuildSemaphore);
break;
+ case DIMENSION:
+ // TODO: Create a DimTableDataManager here when available
Review comment:
`DimTableManager` will have a lot of specific themes related to
preloading the table and also storing the dim table static map, thus it will
muddy the `OfflineTableDataManager` unnecessarily. Thus, we are thinking of
extending the `OfflineTableDataManager` in the new manager class to implement
the extra functionality. We can discuss this in following PRs as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
