siddharthteotia commented on a change in pull request #5746:
URL: https://github.com/apache/incubator-pinot/pull/5746#discussion_r460321729
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java
##########
@@ -632,4 +713,22 @@ public static PinotDataType getPinotDataType(FieldSpec
fieldSpec) {
"Unsupported data type: " + dataType + " in field: " +
fieldSpec.getName());
}
}
+
+ public static PinotDataType getPinotDataTypeFromHashMap(Map<Object, Object>
map) {
Review comment:
Suggest calling it getPrimitivePinotDataTypeFromMap
HashMap is an implementation detail so let's not use that. Map is better
since it is also an interface and suitable to represent an abstract complex type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
