siddharthteotia commented on a change in pull request #5746:
URL: https://github.com/apache/incubator-pinot/pull/5746#discussion_r459805052
##########
File path:
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroUtils.java
##########
@@ -353,16 +353,6 @@ public static Object handleMap(Map map) {
* Handles the conversion of every field of the GenericRecord
*/
private static Object handleGenericRecord(GenericData.Record record) {
- List<Field> fields = record.getSchema().getFields();
Review comment:
It seems that the current implementation of this function is doing what
it is supposed to.
The caller chain is something like convert(value) ->
handleGenericRecord(record). The latter is invoked by the former only if it
determines there is nestedness (that the value passed to convert isn't a SV, MV
or MAP. It is essentially a struct. So for that we need to recurse and call
convert for each field inside GenericData.Record. The fix seems to be removing
all of that code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
