siddharthteotia commented on a change in pull request #5746:
URL: https://github.com/apache/incubator-pinot/pull/5746#discussion_r460321430
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java
##########
@@ -470,6 +474,43 @@ public String toString(Object value) {
}
},
+ HASHMAP,
Review comment:
We actually don't have to introduce this type (in future we should when
we have Map) but now there is no need.
In the transform() method of DataTypeTransformer, we should do:
```
if (values[0] instance of Map) {
// and if schema says the column is primitive
// then get the primitive type from Map using the function you have already
implemented `getPinotDataTypeFromHashMap`
call dest.convert()
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
