yupeng9 commented on a change in pull request #5631:
URL: https://github.com/apache/incubator-pinot/pull/5631#discussion_r454020153
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -202,6 +209,20 @@ private void setupHelixSystemProperties() {
CommonConstants.Helix.DEFAULT_FLAPPING_TIME_WINDOW_MS));
}
+ private void setupHelixClusterConstraints() {
+ String maxMessageLimit =
_config.getString(CommonConstants.Helix.CONFIG_OF_HELIX_INSTANCE_MAX_STATE_TRANSITIONS,
+ CommonConstants.Helix.DEFAULT_HELIX_INSTANCE_MAX_STATE_TRANSITIONS);
+ Map<ClusterConstraints.ConstraintAttribute, String> constraintAttributes =
new HashMap<>();
+ constraintAttributes.put(ClusterConstraints.ConstraintAttribute.INSTANCE,
".*");
+ constraintAttributes
+ .put(ClusterConstraints.ConstraintAttribute.MESSAGE_TYPE,
Message.MessageType.STATE_TRANSITION.name());
+ ConstraintItem constraintItem = new ConstraintItem(constraintAttributes,
maxMessageLimit);
+
+ _helixControllerManager.getClusterManagmentTool()
Review comment:
@mcvsubbu with Junkai's assessment, do you still have concerns on the
current approach, given it's a safe change for better zookeeper scalability?
I prefer the current way since it simplifies the configuration story, i.e.
no need to use external Helix admin to clean up constraint etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
