yupeng9 commented on pull request #5631: URL: https://github.com/apache/incubator-pinot/pull/5631#issuecomment-657712885
I'm flexible on this. As I mentioned in the previous comment, there is a caveat that if the config is not set, then users need to use the Helix admin to remove the constraint with your suggestion. I'm fine with documenting this catch in the documentation. @kishoreg, @Jackie-Jiang are you okay with this? I understand the worry about the use of the less documented feature in Helix, and I hope the Helix community can address it. I also think a wrapper of Helix admin API in Pinot is a good idea for the ease of cluster management: not need to download and setup the ` helix-admin-webapp`. But I think it's valuable to keep this as a Pinot config, so users can use it out of the box, given the disastrous outcome this config can prevent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
