yupeng9 commented on pull request #5631: URL: https://github.com/apache/incubator-pinot/pull/5631#issuecomment-658485856
> The number depends on the capacity of zookeeper to handle transactions. What is to say that 100K is bad and 10K is good? Or that 10M is bad but 1M is not? One reason to use 100K is that `jute.maxbuffer` defaults to 1MB. So the purpose is to protect the controller/server with the out-of-the-box settings. If we had this config, we could have prevented an outage that brought the entire cluster down for hours. > > Why not leave it to whatever helix does by default (i.e. existing behavior) but add a documentation on what helix command sequence to run in order to set the value? (of course, in that case this PR is not needed at all). I believe an inbuilt configuration gives a better user experience, and reliability assurance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
