mayankshriv commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452975868
##########
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/env/PinotConfigurationTest.java
##########
@@ -24,24 +24,116 @@
import java.nio.file.Files;
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;
+import java.util.Arrays;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
+import org.apache.commons.configuration.ConfigurationException;
+import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.pinot.spi.ingestion.batch.spec.PinotFSSpec;
import org.testng.Assert;
import org.testng.annotations.Test;
public class PinotConfigurationTest {
+
+ @Test
+ public void assertBaseOperations() {
Review comment:
I acknowledge that lack of coverage was an issue prior to the
PinotConfiguration change. However, given that this change has a bigger impact,
we run the risk of running into issues each time a specific setup (eg Crypter)
is exercised. I was proposing to simply check the config part of those modules
working.
Ideally, it would have been great to have those tests to begin with. But in
the absence of those (and now that we have run into an issue), the next best
thing would have been adding tests to ensure the coverage before the
PinotConfiguration refactor.
Open to suggestion if you have any, on avoiding running into issues and
fixing them as we find them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
