daniellavoie commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452828229
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentGenerationJobRunner.java
##########
@@ -132,7 +132,7 @@ public void run()
//init all file systems
List<PinotFSSpec> pinotFSSpecs = _spec.getPinotFSSpecs();
for (PinotFSSpec pinotFSSpec : pinotFSSpecs) {
- new PinotConfiguration(pinotFSSpec);
+ PinotFSFactory.register(pinotFSSpec.getScheme(),
pinotFSSpec.getClassName(), new PinotConfiguration(pinotFSSpec));
Review comment:
`PinotConfiguration(map<string,string>)` will conflict with the existing
`PinotConfiguration(map<string,object>)` What I can do is rewrite
`PinotConfiguration(map<string,string>)` as a static function
`PinotConfiguation.fromStringProperties(map<string,object>)` and have that
function include the mapping logic of the current
`PinotConfiguration(PinotFSSpec pinotFSSpec)`. `PinotFSSpec` would be out of
the way with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
