daniellavoie commented on a change in pull request #5674:
URL: https://github.com/apache/incubator-pinot/pull/5674#discussion_r452430603
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentGenerationJobRunner.java
##########
@@ -132,7 +132,7 @@ public void run()
//init all file systems
List<PinotFSSpec> pinotFSSpecs = _spec.getPinotFSSpecs();
for (PinotFSSpec pinotFSSpec : pinotFSSpecs) {
- new PinotConfiguration(pinotFSSpec);
+ PinotFSFactory.register(pinotFSSpec.getScheme(),
pinotFSSpec.getClassName(), new PinotConfiguration(pinotFSSpec));
Review comment:
So, here's my second thoughts about this. `PinotFSSpec.getConfig`
returns a `Map<String, String>` where the the other constructor takes
`Map<String, Object>`. This use case only occurs when `PinotFSSpec` is involve.
If I remove the constructor, I will have to setup an abstract utilitary
function that translates the `Map<String, String>` to `Map<String, Object>`
anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
