mcvsubbu commented on a change in pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#discussion_r439132149
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -29,21 +29,28 @@
import org.apache.pinot.common.protocols.SegmentCompletionProtocol;
import org.apache.pinot.common.utils.StringUtil;
import org.apache.pinot.spi.filesystem.LocalPinotFS;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import static
org.apache.pinot.common.utils.CommonConstants.Controller.CONFIG_OF_CONTROLLER_METRICS_PREFIX;
import static
org.apache.pinot.common.utils.CommonConstants.Controller.DEFAULT_METRICS_PREFIX;
public class ControllerConf extends PropertiesConfiguration {
- private static final Logger LOGGER =
LoggerFactory.getLogger(ControllerConf.class);
-
private static final String CONTROLLER_VIP_HOST = "controller.vip.host";
private static final String CONTROLLER_VIP_PORT = "controller.vip.port";
private static final String CONTROLLER_VIP_PROTOCOL =
"controller.vip.protocol";
private static final String CONTROLLER_HOST = "controller.host";
private static final String CONTROLLER_PORT = "controller.port";
+ private static final String CONTROLLER_HTTP_ENABLED =
"controller.http.enabled";
Review comment:
Does it make sense to do something like:
`controller.access.protocol = "http"` (or, `"https"`, or `"http,https"`)
and then have specific configs for the protocol as:
`controller.access.protocol.<yourConfiguredProtocol>.<protocol-specific-config>`
There is already a `controller.host`, so I suggest we just keep that to be
the same, for existing cloud installations. Otherwise, they will need to
specify the same host name in multiple places. The host name is either
specified or inferred, there are not any other combinations of this. We can
then leave the logic in `ControllerStarter.inferHostNameifNeeded()` as it is
instead of looking at 3 other settings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
