daniellavoie opened a new pull request #5543: URL: https://github.com/apache/incubator-pinot/pull/5543
## Description Introduced new properties to define dynamic listeners to HttpServer. The `controller.port` property is still available and intended to remain supported until future deprecation. * controller.http.enabled * controller.http.host * controller.http.port * controller.https.enabled * controller.https.host * controller.https.port * controller.https.tls.keystore.path * controller.https.tls.keystore.password * controller.https.tls.requires_client_auth * controller.https.tls.truststore.path * controller.https.tls.truststore.password If the legacy `controller.port` is configured, the configuration namespace from `controller.http.*` will be ignored. This is intended to offer a friction less upgrade and rollback mechanism for existing deployments. I purposely created a new configuration namespace to offer a consistent behaviour and backward compatibility of `controller.port` across versions. The old property is involved in the generation of the helix instance id of the Controller. If `controller.port` is undefined then `controller.http.enabled` will be defaulted to `true` and configuration will assert that `controller.http.port` is defined. `host` property for `http` and `https` is defaulted to `0.0.0.0`. Those new properties are only available through config files and not through CLI. CLI users will continue to use `controller.port`. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [X] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes (To be completed) ## Documentation (To be completed) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
