mcvsubbu commented on a change in pull request #5543: URL: https://github.com/apache/incubator-pinot/pull/5543#discussion_r442372420
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java ########## @@ -18,73 +18,110 @@ */ package org.apache.pinot.controller.api; -import com.google.common.base.Preconditions; -import io.swagger.jaxrs.config.BeanConfig; import java.io.IOException; import java.net.URI; import java.net.URL; import java.net.URLClassLoader; +import java.util.List; +import java.util.stream.Collectors; + import javax.ws.rs.container.ContainerRequestContext; import javax.ws.rs.container.ContainerResponseContext; import javax.ws.rs.container.ContainerResponseFilter; + +import org.apache.pinot.controller.api.listeners.ListenerConfig; +import org.apache.pinot.controller.api.listeners.TlsConfiguration; import org.glassfish.grizzly.http.server.CLStaticHttpHandler; import org.glassfish.grizzly.http.server.HttpServer; +import org.glassfish.grizzly.http.server.NetworkListener; +import org.glassfish.grizzly.ssl.SSLContextConfigurator; +import org.glassfish.grizzly.ssl.SSLEngineConfigurator; import org.glassfish.hk2.utilities.binding.AbstractBinder; import org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpServerFactory; +import org.glassfish.jersey.internal.guava.ThreadFactoryBuilder; import org.glassfish.jersey.jackson.JacksonFeature; import org.glassfish.jersey.media.multipart.MultiPartFeature; +import org.glassfish.jersey.process.JerseyProcessingUncaughtExceptionHandler; import org.glassfish.jersey.server.ResourceConfig; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.google.common.base.Preconditions; + +import io.swagger.jaxrs.config.BeanConfig; + public class ControllerAdminApiApplication extends ResourceConfig { private static final Logger LOGGER = LoggerFactory.getLogger(ControllerAdminApiApplication.class); private HttpServer httpServer; Review comment: Good time to change this to `_httpServer` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org