npawar commented on a change in pull request #5320:
URL: https://github.com/apache/incubator-pinot/pull/5320#discussion_r418281787
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/RealtimeSegmentConverter.java
##########
@@ -35,114 +35,116 @@
import
org.apache.pinot.core.segment.creator.impl.SegmentIndexCreationDriverImpl;
import org.apache.pinot.spi.config.table.ColumnPartitionConfig;
import org.apache.pinot.spi.config.table.SegmentPartitionConfig;
+import org.apache.pinot.spi.config.table.TableConfig;
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.data.Schema;
import org.apache.pinot.spi.data.TimeFieldSpec;
import org.apache.pinot.spi.data.TimeGranularitySpec;
public class RealtimeSegmentConverter {
- private MutableSegmentImpl realtimeSegmentImpl;
- private String outputPath;
- private Schema dataSchema;
- private String tableName;
- private String timeColumnName;
- private String segmentName;
- private String sortedColumn;
- private List<String> invertedIndexColumns;
- private List<String> textIndexColumns;
- private List<String> noDictionaryColumns;
- private List<String> varLengthDictionaryColumns;
+ private MutableSegmentImpl _realtimeSegmentImpl;
+ private final String _outputPath;
+ private final Schema _dataSchema;
+ private final String _tableName;
+ private final TableConfig _tableConfig;
+ private final String _segmentName;
+ private final String _sortedColumn;
+ private final List<String> _invertedIndexColumns;
+ private final List<String> _textIndexColumns;
+ private final List<String> _noDictionaryColumns;
+ private final List<String> _varLengthDictionaryColumns;
private final boolean _nullHandlingEnabled;
public RealtimeSegmentConverter(MutableSegmentImpl realtimeSegment, String
outputPath, Schema schema,
- String tableName, String timeColumnName, String segmentName, String
sortedColumn,
+ String tableName, TableConfig tableConfig, String segmentName, String
sortedColumn,
Review comment:
Oh i see. Maybe they can be. In LLRealtimeDataManager, they're being
pulled from IndexLoadingConfig. In HLRealtimeDataManager, they're being used in
other places other than RealtimeSegmentConverter. Will see if it can be done in
a followup PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
