npawar commented on a change in pull request #5320: URL: https://github.com/apache/incubator-pinot/pull/5320#discussion_r418238005
########## File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java ########## @@ -85,7 +85,10 @@ public File purgeSegment() } Schema schema = purgeRecordReader.getSchema(); - SegmentGeneratorConfig config = new SegmentGeneratorConfig(schema); + // FIXME: figure out how to get table config here. Review comment: Was able to fix it. please take a look ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org