npawar opened a new pull request #5320: URL: https://github.com/apache/incubator-pinot/pull/5320
This is an item for this project: https://github.com/apache/incubator-pinot/issues/2756 One of the initial steps is - in all places where primary time column is needed, refer to timeColumnName in tableConfig, instead of from schema. Then use the timeColumnName to fetch the fieldSpec from schema. Major changes: 1) Removing SegmentGeneratorConfig(Schema schema) constructor. Enforcing the usage of SegmentGeneratorConfig(TableConfig tableConfig, Schema schema) instead. This allows us to read time from table config. 2) If table config is not available, reading timeSpec. This will change to reading 1st dateTimeFieldSpec soon. This will fail if we have multiple dateTimeFieldSpecs and no table config defined. Pending: 1) Haven't figured out how to bring table config to SegmentPurger ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
