xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3041143665
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java:
##########
@@ -911,24 +909,35 @@ private MetricFieldSpec
constructNewMetric(FieldSpec.DataType dataType) {
return new MetricFieldSpec(column, dataType);
}
+ protected RebalanceResult triggerTableRebalance(RebalanceConfig
rebalanceConfig, TableType tableType)
+ throws IOException, PinotAdminException {
+ Map<String, String> queryParams = new HashMap<>();
+ queryParams.put("type", tableType.toString());
+ String[] params = rebalanceConfig.toQueryString().split("&");
+ for (String param : params) {
+ String[] kv = param.split("=", 2);
+ if (kv.length == 2) {
+ queryParams.put(kv[0], kv[1]);
+ }
+ }
+ return getOrCreateAdminClient().getRebalanceClient()
Review Comment:
rebalanceTable() should return `RebalanceResult` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]