xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3040980297
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotControllerAppConfigsTest.java:
##########
@@ -46,16 +45,15 @@ public void setUp()
/**
* Asserts that app configurations returned by the controller endpoint
* are as expected.
- * @throws IOException In case of exception
*/
@Test
public void testControllerAppConfigs()
- throws IOException {
+ throws Exception {
ControllerConf expectedControllerConf =
TEST_INSTANCE.getControllerConfig();
PinotAppConfigs expected = new PinotAppConfigs(expectedControllerConf);
- String configsJson =
ControllerTest.sendGetRequest(TEST_INSTANCE.getControllerRequestURLBuilder().forAppConfigs());
- PinotAppConfigs actual = JsonUtils.stringToObject(configsJson,
PinotAppConfigs.class);
+ PinotAppConfigs actual =
TEST_INSTANCE.getOrCreateAdminClient().getClusterClient().getAppConfigs(
Review Comment:
Done - getAppConfigs() now returns PinotAppConfigs directly. Removed the
Class<T> overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
