xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3041146232
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java:
##########
@@ -940,16 +949,10 @@ protected void waitForRebalanceToComplete(String
rebalanceJobId, long timeoutMs)
protected void waitForTableEVISConverge(String tableName, long timeoutMs) {
TestUtils.waitForCondition(aVoid -> {
try {
- String requestUrl =
getControllerRequestURLBuilder().forIdealState(tableName);
- SimpleHttpResponse httpResponse =
-
HttpClient.wrapAndThrowHttpException(getHttpClient().sendGetRequest(new
URL(requestUrl).toURI(), null));
TableViews.TableView idealState =
- JsonUtils.stringToObject(httpResponse.getResponse(),
TableViews.TableView.class);
-
- requestUrl =
getControllerRequestURLBuilder().forExternalView(tableName);
- httpResponse = getHttpClient().sendGetRequest(new
URL(requestUrl).toURI(), null);
+ getOrCreateAdminClient().getTableClient().getIdealState(tableName,
TableViews.TableView.class);
Review Comment:
getIdealState() should return TableView directly
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java:
##########
@@ -940,16 +949,10 @@ protected void waitForRebalanceToComplete(String
rebalanceJobId, long timeoutMs)
protected void waitForTableEVISConverge(String tableName, long timeoutMs) {
TestUtils.waitForCondition(aVoid -> {
try {
- String requestUrl =
getControllerRequestURLBuilder().forIdealState(tableName);
- SimpleHttpResponse httpResponse =
-
HttpClient.wrapAndThrowHttpException(getHttpClient().sendGetRequest(new
URL(requestUrl).toURI(), null));
TableViews.TableView idealState =
- JsonUtils.stringToObject(httpResponse.getResponse(),
TableViews.TableView.class);
-
- requestUrl =
getControllerRequestURLBuilder().forExternalView(tableName);
- httpResponse = getHttpClient().sendGetRequest(new
URL(requestUrl).toURI(), null);
+ getOrCreateAdminClient().getTableClient().getIdealState(tableName,
TableViews.TableView.class);
TableViews.TableView externalView =
- JsonUtils.stringToObject(httpResponse.getResponse(),
TableViews.TableView.class);
+
getOrCreateAdminClient().getTableClient().getExternalView(tableName,
TableViews.TableView.class);
Review Comment:
getIdealState() should return TableView directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
