xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3038859621
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java:
##########
@@ -351,10 +352,19 @@ private TableView getTableIdealState(String
tableNameOptType, @Nullable TableTyp
private TableView getTableExternalView(String tableNameOptType, @Nullable
TableType tableType) {
TableView tableView = new TableView();
if (tableType == null || tableType == TableType.OFFLINE) {
- tableView._offline = getExternalView(tableNameOptType,
TableType.OFFLINE);
+ Map<String, Map<String, String>> external =
getExternalView(tableNameOptType, TableType.OFFLINE);
+ if (external == null || external.isEmpty()) {
+ // Fallback to ideal state if external view is not yet materialized.
+ external = getIdealState(tableNameOptType, TableType.OFFLINE);
Review Comment:
no fallback to idealstate.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java:
##########
@@ -351,10 +352,19 @@ private TableView getTableIdealState(String
tableNameOptType, @Nullable TableTyp
private TableView getTableExternalView(String tableNameOptType, @Nullable
TableType tableType) {
TableView tableView = new TableView();
if (tableType == null || tableType == TableType.OFFLINE) {
- tableView._offline = getExternalView(tableNameOptType,
TableType.OFFLINE);
+ Map<String, Map<String, String>> external =
getExternalView(tableNameOptType, TableType.OFFLINE);
+ if (external == null || external.isEmpty()) {
+ // Fallback to ideal state if external view is not yet materialized.
+ external = getIdealState(tableNameOptType, TableType.OFFLINE);
+ }
+ tableView._offline = external;
}
if (tableType == null || tableType == TableType.REALTIME) {
- tableView._realtime = getExternalView(tableNameOptType,
TableType.REALTIME);
+ Map<String, Map<String, String>> external =
getExternalView(tableNameOptType, TableType.REALTIME);
+ if (external == null || external.isEmpty()) {
+ external = getIdealState(tableNameOptType, TableType.REALTIME);
Review Comment:
no fallback to idealstate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
