xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3038847715
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/http/PinotConnectionUtils.java:
##########
@@ -38,18 +38,23 @@ public final class PinotConnectionUtils {
private PinotConnectionUtils() {
}
- public static Schema getSchema(ControllerRequestClient client, String
tableName) {
+ public static Schema getSchema(PinotAdminClient client, String tableName) {
try {
- return client.getSchema(tableName);
+ return client.getSchemaClient().getSchema(tableName);
} catch (Exception e) {
throw new RuntimeException(String.format("Failed to get table schema %s
from Pinot controller", tableName), e);
}
}
- public static TableConfig getTableConfig(ControllerRequestClient client,
String tableName, String tableType) {
+ public static TableConfig getTableConfig(PinotAdminClient client, String
tableName, String tableType) {
TableConfig tableConfig;
try {
- tableConfig = client.getTableConfig(tableName,
TableType.valueOf(tableType));
+ String configJson = client.getTableClient().getTableConfig(tableName,
tableType);
Review Comment:
PinotAdminClient.getTableClient().getTableConfig() should return
`TableConfig` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
