xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3038818600
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotTableAdminClient.java:
##########
@@ -369,4 +974,18 @@ public CompletableFuture<String> createTableAsync(String
tableConfig, String val
return _transport.executePostAsync(_controllerAddress, "/tables",
tableConfig, queryParams, _headers)
.thenApply(JsonNode::toString);
}
+
+ private Map<String, String> mergeHeaders(@Nullable Map<String, String>
headers) {
Review Comment:
Extract mergeHeaders and other common methods in the client classes to a
common interface or abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
