ankitsultana commented on code in PR #17421:
URL: https://github.com/apache/pinot/pull/17421#discussion_r2650198267
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -382,6 +379,9 @@ public void start()
org.apache.pinot.spi.config.instance.InstanceType.BROKER);
_threadAccountant.startWatcherTask();
+ // TODO: Hook multiClusterRoutingContext into request handlers
subsequently.
+ MultiClusterRoutingContext multiClusterRoutingContext =
getMultiClusterRoutingContext();
Review Comment:
Hmm I thought about this. I think we can leave this be. In the next PR, can
you change the local var to an `Optional.ofNullable`? Just so it is clear for
other folks that this will be null in almost all cases (except federated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
