shauryachats commented on code in PR #17421:
URL: https://github.com/apache/pinot/pull/17421#discussion_r2646127636
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -382,6 +379,9 @@ public void start()
org.apache.pinot.spi.config.instance.InstanceType.BROKER);
_threadAccountant.startWatcherTask();
+ // TODO: Hook multiClusterRoutingContext into request handlers
subsequently.
+ MultiClusterRoutingContext multiClusterRoutingContext =
getMultiClusterRoutingContext();
Review Comment:
We need to initialize this in BaseBrokerStarter since it would be passed to
all the request handlers subsequently. Alternatively, we could separate out
initializing the request handlers in a separate method which can be overriden
by MultiClusterHelixBrokerStarter. (The only thing there is we would be passing
nulls for multiClusterRoutingContext in BaseBrokerStarter regardless).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
