ankitsultana commented on code in PR #17421: URL: https://github.com/apache/pinot/pull/17421#discussion_r2644628236
########## pinot-core/src/main/java/org/apache/pinot/core/routing/MultiClusterRoutingContext.java: ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.routing; + +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.pinot.common.config.provider.TableCache; + + +/** + * A generic class which provides the dependencies for federation routing. + * This class is responsible for managing routing managers and providing the appropriate + * routing manager based on query options (e.g., whether federation is enabled). + */ +public class MultiClusterRoutingContext { Review Comment: this is only a sink right now. would you be adding logic to this in a future PR? ########## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ########## @@ -382,6 +379,9 @@ public void start() org.apache.pinot.spi.config.instance.InstanceType.BROKER); _threadAccountant.startWatcherTask(); + // TODO: Hook multiClusterRoutingContext into request handlers subsequently. + MultiClusterRoutingContext multiClusterRoutingContext = getMultiClusterRoutingContext(); Review Comment: Why is this initialized in base broker starter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
