yashmayya commented on code in PR #17342:
URL: https://github.com/apache/pinot/pull/17342#discussion_r2620634776
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -362,6 +362,10 @@ private List<QueryServerInstance>
getCandidateServers(DispatchablePlanContext co
} else {
candidateServers = getCandidateServersPerTables(context);
}
+ // Sort to ensure deterministic worker ID assignment across stages.
Review Comment:
> Yeah, this is more for future proof.
If we don't want the singleton to be deterministic, we can move the sort to
the caller side, given we don't need to sort for singleton case
That's a fair point, I've moved the sort to the caller side in the
intermediate stage worker assignment logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
