gortiz commented on code in PR #17342:
URL: https://github.com/apache/pinot/pull/17342#discussion_r2618414662


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -362,6 +362,10 @@ private List<QueryServerInstance> 
getCandidateServers(DispatchablePlanContext co
     } else {
       candidateServers = getCandidateServersPerTables(context);
     }
+    // Sort to ensure deterministic worker ID assignment across stages.

Review Comment:
   > E.g. there is a JOIN over 2 sorted projection, where the planner 
identifies both side as colocated
   
   Why do we need an exchange in that case? Isn't that kind of exchange just a 
noop? Couldn't we fuse these two stages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to