yashmayya commented on code in PR #17342:
URL: https://github.com/apache/pinot/pull/17342#discussion_r2612202917
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -362,6 +362,10 @@ private List<QueryServerInstance>
getCandidateServers(DispatchablePlanContext co
} else {
candidateServers = getCandidateServersPerTables(context);
}
+ // Sort to ensure deterministic worker ID assignment across stages.
Review Comment:
> where the planner identifies both side as colocated
I guess this shouldn't be possible right now because the sort worker's
distribution is hash with empty keys? Also the join stage should anyway not be
a singleton and hence we wouldn't be using the direct exchange logic right
(even if the planner marks it as pre-partitioned)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
