yashmayya commented on code in PR #17109: URL: https://github.com/apache/pinot/pull/17109#discussion_r2558169830
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/aggregate/AvgWindowValueAggregator.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator.window.aggregate; + +import javax.annotation.Nullable; + + +/** + * Window value aggregator for AVG window function. + */ +public class AvgWindowValueAggregator implements WindowValueAggregator<Object> { Review Comment: If we retain the `AVG` window function rewrite to `SUM` / `COUNT` (by retaining the standard operator), we also need to retain the standard `SUM` operator. The reason is that Calcite uses the standard `SUM` operator when rewriting the `AVG` window function and it can't then deduplicate `SUM` in queries like `SELECT AVG(col) OVER(), SUM(col) OVER()...` (due to the different operator instances used), but interestingly it is able to do so for `SELECT AVG(col), SUM(col)...` (presumably because the latter is using `SqlKind` instead). I've reverted to using the standard `SUM` and `AVG` operators for now. We can switch to using custom ones (for the operand type checker to allow array / MV types) after the next release (which should contain https://github.com/apache/pinot/pull/17268). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
