yashmayya commented on PR #17109: URL: https://github.com/apache/pinot/pull/17109#issuecomment-3583531480
It's not expected to cause any issues, because we've replicated the function overrides and they should be semantically equivalent apart from the modified operand type checker / return type inference to support array types. If there were any weird Calcite edge cases that relied on the exact standard Calcite operator (like we saw for `AVG` -> `SUM` above), our test cases should have caught it IMO. I've updated the PR description though to call out this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
