Jackie-Jiang commented on code in PR #17109:
URL: https://github.com/apache/pinot/pull/17109#discussion_r2543755000
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -141,18 +141,10 @@ public abstract class BaseSingleStageBrokerRequestHandler
extends BaseBrokerRequ
private static final Expression STAR =
RequestUtils.getIdentifierExpression("*");
private static final int
MAX_UNAVAILABLE_SEGMENTS_TO_PRINT_IN_QUERY_EXCEPTION = 10;
private static final Map<String, String>
DISTINCT_MV_COL_FUNCTION_OVERRIDE_MAP = Map.ofEntries(
- Map.entry("distinctcount", "distinctcountmv"),
Review Comment:
We should not change function override in the same PR. We need to add the
function first, then wait for one release before changing the broker override.
Otherwise existing queries will fail once we upgrade broker.
We should consider adding a test in the backward compatibility suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
