yashmayya commented on PR #17058: URL: https://github.com/apache/pinot/pull/17058#issuecomment-3444571886
Actually, thinking about this some more, I don't think it's safe to do this rewrite automatically without a two phase release (https://github.com/apache/pinot/pull/17001 hasn't been released yet). If brokers are upgraded before servers (which is our recommended upgrade order - https://docs.pinot.apache.org/operators/operating-pinot/upgrading-pinot-cluster), then the query can be rewritten by the broker to use aggregation functions that are not yet supported by the servers which would lead to query failures during the upgrade process. IMO we need to first enable this rewrite using a query option or broker config which defaults to false. After the next release, we can change the default to true, or remove the option completely and do the rewrite automatically by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
